Repository navigation
Support processor-backed sessions - #10682
Open
markerikson wants to merge 8 commits into
Open
markerikson wants to merge 8 commits into
markerikson wants to merge 8 commits into
Conversation
- Panel visibility from Session.getLibraryStatus, with a failed state - React panel from React.getComponentTree, synthesized into RDT operations - Redux panel from Redux.getActions - Jump-to-code from Session.getInteractionHandlers
E2E tests add it when E2E_PROCESSOR_SESSIONS is set.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
@replayio/protocolto 0.106.0 for the processor-session commandsRecording.createSessionreturned a processor-backed session (processorBackedin the app slice,replayClient.isProcessorBacked())React.getComponentTreeat each pauseRedux.getActionsto the existing action annotation shapeSession.getInteractionHandlersto the existing jump annotation shapeSession.getLibraryStatus, including a new error message when the backend reportsfailed?processorURL param that requests a processor session viaexperimentalSettings.useProcessorController, andE2E_PROCESSOR_SESSIONS=1to pass it in e2e runsController sessions use the same annotation code paths as before.
🤖 Description
Details
listenerPointfromgetInteractionHandlersis a bareExecutionPoint, but seeking needs a time.listenerPointCachelooks it up on click withfindPointsat the handler'sfirstBreakablePosition, limited to that point. A backend follow-up will send aTimeStampedPoint, and then the lookup can go.getLibraryStatuscalls took 20-190 s.E2E results against prod processor sessions
Production build against
wss://dispatch.replay.io. Controller: 91 passed, 10 failed (9 environment failures inauthenticated/*and the redux-fundamentals example, plusrepaint-06). Processor: the same 9, 11 that fail only from cold starts under parallel load, and 6 others:react_devtools-01: fixed in this PRfile-search-01,logpoints-07: the processor does not pretty-print content-hashed bundles (backend fix pending)react_devtools-02: old recording's runtime can't run the React analysis; needs re-recordingreact_devtools-03: React 16 is unsupported by the analysis engine; test/example change neededplaywright-04: playback stalls while screenshot requests wait behind a long evaluation (backend)