Repository navigation
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Remove Discovery's deprecated Node/Python structural-validation aliases and their generated facade exports. Adopters use
validateSelectionStructureorvalidate_selection_structure, then explicitly accept a selection through local policy.Fresh Messaging schemas contain only the shared activation ledger. Remove the unused legacy table creation and cover the resulting schema with a real PostgreSQL regression. This is a fresh baseline change, with no legacy-state migration.
Verification
Current pushed head:
4e88d0e540d699ce8fd5c1a45adf432cd6872601, based on PR #2040 at6965700ae483975a0b6678c5c0431555577e34c2. Review againstjeremi/product-cleanup-integration. The signed-off base synchronization preserves the exact reviewed 22-file feature diff; facade sync, all three facade tests and TypeScript pass.The maintained manual CI workflow passed on this exact synchronized head with normal changed-path selection: 54 successful jobs and three skipped. Automatic CI does not select this stacked base. The synchronized base includes independently accepted BReg Review identity and Coordinator terminal-evidence corrections, preserving the legitimate restore-review case. Final base proof passes 229 BReg, 42 Coordinator and ten Rust facade tests, a real PostgreSQL recovery/retention regression, and freshly rebuilt installed public tests (108 Node, 127 Python). Earlier fixture and interrupted-S3 corrections remain included. Independent feature and base-correction review are complete. The initial automated review failed on f28 and supplies no automated clearance; base PR #2040's automatic review completed on its current head at 14:12Z without new findings. Current-head CI is complete. Base PR #2040 is also green and conflict-free, but its 264 commits exceed the configured rebase queue's 100-commit limit; that merge-method decision remains open.
No release, deployment, external publication or main-branch merge is included.