Skip to content

test(e2e): Carry 1-019_validate_rolebindings_with_managed_by_test.go from argocd-operator - #1435

Open
olivergondza wants to merge 2 commits into
redhat-developer:masterfrom
olivergondza:test-sequential-unify-unique-2
Open

olivergondza wants to merge 2 commits into
redhat-developer:masterfrom
olivergondza:test-sequential-unify-unique-2

Conversation

@olivergondza

Copy link
Copy Markdown
Collaborator

What does this PR do?

The E2E test is otherwise not run.

PR acceptance criteria:

  • [no] Documentation was updated and verified using make serve-docs
  • [no] Unit tests were updated
  • E2E tests were updated

What type of PR is this?

/kind enhancement

Special notes to the reviewer:

…from argocd-operator

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
…into test-sequential-unify-unique-2

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@openshift-ci openshift-ci Bot added kind/enhancement New feature or request needs-rebase labels Oct 19, 2026
@openshift-ci

openshift-ci Bot commented Oct 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 051b3068-5f60-4b25-a4b8-92a463266ab2
📥 Commits

Reviewing files that changed from the base of the PR and between b6777be and f455987.

📒 Files selected for processing: 1
  • test/openshift/e2e/ginkgo/sequential/1-019_validate_rolebindings_with_managed_by_test.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

💤 Files with no reviewable changes: 1
  • test/openshift/e2e/ginkgo/sequential/1-019_validate_rolebindings_with_managed_by_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • Reorganized an end-to-end test into the standard test directory.
    • Test coverage and behavior remain unchanged.

The pull request moves one E2E test file to test/openshift/e2e/ginkgo/sequential/. The file content and test logic remain unchanged.

Changes

Cohort / File(s) Summary
Test relocation
test/openshift/e2e/ginkgo/sequential/1-019_validate_rolebindings_with_managed_by_test.go
Moves the test file to the current OpenShift E2E sequential test directory. No content changes are reported.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f4559

This change only relocates an end-to-end test so that it runs. It does not alter production behavior and carries no identified merge risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the E2E test being carried from argocd-operator.
Description check Passed The description explains that the E2E test is carried because it is otherwise not run.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant