Repository navigation
chore(deps): update go-git, argocd, go-scm and golang - #74
Merged
openshift-merge-bot[bot] merged 8 commits intoOct 13, 2026
Merged
Conversation
Signed-off-by: Kanika Rana <krana@redhat.com>
Contributor
Author
|
golangci-lint run pass locally, |
Signed-off-by: Kanika Rana <krana@redhat.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
Contributor
Author
|
updates filepath-securejoin as well to avoid build error: |
Contributor
Author
|
build is still failing with the same error;
we should update argocd to v3.3 where this is resolved by 25228 - argocd v3.3. maps to our lowest in-release gitops-operator version v1.20 as well |
Signed-off-by: Kanika Rana <krana@redhat.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
ranakan19
changed the title
Contributor
Author
|
/retest |
Signed-off-by: Kanika Rana <krana@redhat.com>
ranakan19
commented
Oct 12, 2026
| # Dockerfile to bootstrap build and test in openshift-ci | ||
|
|
||
| FROM quay.io/devtools_gitops/go-toolset:1.26.2 | ||
| FROM quay.io/devtools_gitops/go-toolset:1.26.3 |
Contributor
Author
There was a problem hiding this comment.
to fix ci failure:
go mod vendor
go: go.mod requires go >= 1.26.3 (running go 1.26.2; GOTOOLCHAIN=local)
ranakan19
commented
Oct 12, 2026
| name: openshift-gitops-go-toolset | ||
| namespace: ci | ||
| tag: 1.26.2 | ||
| tag: 1.26.3 |
Contributor
Author
There was a problem hiding this comment.
to fix ci failure:
go mod vendor
go: go.mod requires go >= 1.26.3 (running go 1.26.2; GOTOOLCHAIN=local)
Contributor
Author
|
/retest AWS bootstrap/install timeout |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Oct 13, 2026
f91b189
into
redhat-developer:master
9 checks passed
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*What type of PR is this?
/kind bug
vulnerability fix
What does this PR do / why we need it:
CVE-2026-71556 fix needs go-git/go-git to be upgraded to 5.19.2
but the cascading effect results in the following additional upgrade to have a green build:
more info in https://redhat-internal.slack.com/archives/C01RQH8KQ87/p1791579548204409?thread_ts=1791559776.199049&cid=C01RQH8KQ87
Have you updated the necessary documentation? N/A
Which issue(s) this PR fixes:
fixes CVE-2026-71556
How to test changes / Special notes to the reviewer: