Conversation
jboyens
force-pushed
the
jboyens/fix-remove-deprecated-buffer-c/wzuzvkwnrwkw
branch
from
September 25, 2026 17:05
e80c13e to
225bbea
Compare
domharrington
approved these changes
Sep 28, 2026
domharrington
left a comment
domharrington
left a comment
Member
There was a problem hiding this comment.
LGTM. The type fixes could've been done separately, but I also think it's fine. Would be curious to see some benchmarks of how this performs on the gitto side.
Member
There was a problem hiding this comment.
Idk how much test coverage we should be adding for all of these different error states? Is this a branch that we should be testing?
Comment on lines
-1127
to
+1130
| .catch(function() { | ||
| .catch(function(error) { | ||
| if (error.errno !== NodeGit.Error.CODE.ENOTFOUND) { | ||
| throw error; | ||
| } |
| }); | ||
| }); | ||
|
|
||
| it("rejects operations on a freed repository without invoking libgit2", function() { |
Member
There was a problem hiding this comment.
Oh maybe this is the tests I was asking about before?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
free()method and tweaks descendant objects to track@types/nodegit🧬 QA & Testing
Provide as much information as you can on how to test what you've done.