Repository navigation
Make the libraries' components standalone; prefer-standalone is an error - #419
Merged
Merged
Conversation
The last of #322's migrations. reactome-table's three components were converted by Angular's standalone migration; GsaFormComponent, which the migration left, by hand: it imports what its template uses (the build's NG8113 named the rest), and GsaFormModule imports it rather than declaring it. Both NgModules stay as thin wrappers with the same exports, providers, store and effects features and routing, so pathway-browser and reactome-table-wc import them unchanged. GsaFormModule's bootstrap entry, meaningless in a feature module, is dropped. DropdownComponent was listed in GsaFormModule and used in no template anywhere; it is deleted. With no non-standalone component left, @angular-eslint/prefer-standalone is promoted to an error, and the lint baseline drops from 1453 warnings to 1448. Closes #322. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #322: the last of its migrations.
reactome-table:TableComponent,UploadTableComponentandDownloadTableComponentconverted by Angular'sstandalonemigration (convert-to-standalonemode).ReactomeTableModuleimports and exports them in place of declaring them.reactome-gsa-form:GsaFormComponent, which the migration left, was converted by hand. It imports only what its template uses; the build's NG8113 named the 17 that it didn't.GsaFormModuleimports it instead of declaring it, and keeps its exports,TourUtilsServiceprovider, store and effects features, and routing. Itsbootstrapentry, meaningless in a feature module, is dropped.pathway-browser(GsaFormModule,ReactomeTableModule) andreactome-table-wc(ReactomeTableModule) import them unchanged.DropdownComponent(gsa-dropdown) deleted: it was listed inGsaFormModuleand used in no template anywhere. Nothing imports it, whichknipreported once the module stopped listing it.@angular-eslint/prefer-standalonehas no findings left and is promoted to error. The lint baseline drops from 1453 warnings to 1448: the rule's 4, plus 1no-explicit-anythat was in the deleted dropdown.Tests
build:libs,ng build reactome-table-wc,npm run buildandbuild:embedall succeed.reactome-table) and quantitative (GSA form) analysis specs.check:typesok;check:lintat the new baseline;check:deadunchanged.🤖 Generated with Claude Code