Repository navigation
Make CI green again: pin json below 3 on Rails < 8.1 lanes, fix RuboCop offenses - #9
Merged
Merged
Conversation
…op offenses Two independent breaks had main red since 2026-08-31: - lint: the 0.3.3 actor_class commit left three autocorrectable offenses (Layout/ArgumentAlignment twice in test/configuration_test.rb, Style/DirectiveScope in test/documentation_examples_test.rb). Applied RuboCop's own corrections. - sqlite lanes on Rails 7.1, 7.2 and 8.0: json 3.x (3.0.0 on 2026-09-08) rejects the quirks_mode: keyword that ActiveSupport < 7.2.4 and 8.0.x still pass to JSON.generate. The install migration JSON-encodes a column default, so db:migrate died before a single test ran. json is pinned to ~> 2.7 on those three appraisals (same pin chats and pricing_plans carry); Rails 8.1 is untouched and runs json 3. Verified locally on Ruby 3.4.7: 837 runs, 0 failures on each of the 7.1, 7.2 and 8.0 gemfiles; rubocop reports no offenses. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKwnuouKrCTFGCidHgwSuS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Testsonmainhas been red since the 0.3.3 release on 2026-08-31 (latest run 39176873199), for two unrelated reasons:actor_classcommit:Layout/ArgumentAlignment×2 intest/configuration_test.rb,Style/DirectiveScopeintest/documentation_examples_test.rb.quirks_mode:toJSON.generate; the install migration JSON-encodes a column default, sodb:migratedied before any test ran. The Rails 8.1 lanes were green.What
-a, then-Afor the directive-scope one: the disable/enable pair becomes# rubocop:disable-next Security/Eval).gem "json", "~> 2.7"on the 7.1, 7.2 and 8.0 appraisals and their generated gemfiles. Same pin chats and pricing_plans carry. Rails 8.1 keeps json 3.Verified locally (Ruby 3.4.7)
Test gemfiles and lint only, no library code touched; CI is the review.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FKwnuouKrCTFGCidHgwSuS