Repository navigation
http: keep trigger events in call order - #85
Merged
Merged
Conversation
The rs:event handler passed each detail to htmx.trigger as is, while
HTMX prepares every HX-Trigger entry first. A repeated event with a
primitive detail therefore threw a TypeError in HTMX 2 (strict mode),
and HTMX 4 listeners received "a" instead of { value: "a" }.
Prepare each entry the way the loaded HTMX version does:
- HTMX 1.x wraps non-objects in { value } and ignores "target";
- HTMX 2.x also applies "target" to this and all following events;
- HTMX 4.x passes any object as is and applies "target" to one event.
Pending events were stored in a dictionary that mixed two kinds of
values. SmallDictionary sorted its keys after five entries, and repeats
were written at the position of the first repeat, so the browser could
receive events out of call order.
- Store the events of each timing in a list.
- Write events as object properties when their names are unique. When a
name repeats, write all events of the header under "rs:event" in call
order.
- Send event names as given instead of converting them to camelCase.
- Write a null detail as {"value":null}. HTMX 1.x and 2.x already wrap
it this way, and HTMX 4.x fails on null.
- Return IReadOnlyList<KeyValuePair<string, string>> from the
HtmxResponseHeaders.Trigger* properties.
The buffer is needed only while Flush writes the HX-Trigger* headers, but as a field it stayed reachable from HttpContext.Items until the request ended. Create it in Flush and pass it to SetHeader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.