fix(marketing): dedupe nav icons, point Discord at # - #8
Merged
Merged
Conversation
- drop stray <slot name="secondary" /> from the primary nav ul (#7 added it, so github/discord/discussions/theme rendered in both desktop navs) - discord icon links to # like the footer and docs do; discord.gg/pywire is not a valid invite
reecelikesramen
force-pushed
the
fix/nav-dup-discord
branch
from
September 24, 2026 03:34
d1d21a8 to
d03de63
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prod currently renders github/discord/discussions/theme-toggle twice in the desktop nav — #7 added a stray
<slot name="secondary" />to the primary nav ul on top of the existing secondary nav.Also points the header Discord icon at
#(matching the footer and the docs site):discord.gg/pywireis not a valid invite code.Verified locally: built site has one visible icon set, zero
discord.ggrefs,pnpm build+pnpm checkpass.