[docker] Run stubtest on Windows to cover the named pipe transport - #16422
Open
SharoonSharif wants to merge 1 commit into
Open
SharoonSharif wants to merge 1 commit into
SharoonSharif wants to merge 1 commit into
Conversation
docker-py installs pywin32 on Windows, so docker.transport.npipeconn and docker.transport.npipesocket import there and stubtest reported the global allowlist entries for them as unused. Move those entries to the linux and darwin allowlists, where the modules fail to import, and add win32 to ci-platforms so the npipe stubs are checked against the runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-py declares
pywin32>=304; sys_platform == "win32", so on Windowsdocker.transport.npipeconnanddocker.transport.npipesocketimport and stubtest fails with two unused allowlist entries. On Linux, where CI runs, the modules never import, so the named pipe stubs are never checked against the runtime.This moves the two entries to the linux and darwin allowlists and adds
win32toci-platformsso the named pipe transport is tested where it exists.Upstream: npipesocket.py, npipeconn.py, pyproject.toml dependency.
Agent used: Claude Code.