Repository navigation
Conversation
Documentation build overview
|
limadog9
force-pushed
the
gh-131723-fmean-decimal-weights
branch
from
October 20, 2026 12:50
5d47741 to
e2b21cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weighted
fmean()currently divides aDecimalnumerator by a float denominator, raisingTypeErroreven when the data and weights have compatible types. Convert the numerator to float before division so these inputs produce the documented float result.Following the approach suggested in the issue, clarify in the documentation and docstring that weighted inputs must support multiplication with each other. Mixed Decimal/float and Decimal/Fraction inputs remain unsupported. Add regression coverage for Decimal data, Decimal weights, and both together.
Fixes #131723.
Validation: