Repository navigation
gh-158688: Fix crash when dumping a deep chain of awaiting tasks - #158690
deadlovelll wants to merge 1 commit into
Conversation
|
I think this is a duplicate of #153365 |
hi! yes, i see problems overlaps. But solutions differ #153365 keeps no visited set, so the check if there are infinite loop or not only depends on the const (MAX_TASK_WAITER_WALK_TASKS). For example repro from #158688 with But actually the program does not produce the infinite loop I don't think these PRs compete, #153365 covers things mine doesn't. Feel free to cherry pick this commit into your PR =) |
|
@deadlovelll I fully agree that the visited set is a valuable addition. Do you want to tackle this, now once #153365 landed? |
yeah sure |
I'm gonna close this and open the new one, it's gonna be simpler rather than trying to merge |
Fix crash when dumping a deep chain of awaiting tasks
For more details see gh-158688