Fix unnumbered list item's text alignment in 'Thread safety for set objects' - #158261
Merged
Merged
Conversation
bedevere-app
Bot
added
docs
StanFromIreland
changed the title
StanFromIreland
added
needs backport to 3.13
|
Thanks @rffontenelle for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @rffontenelle for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @rffontenelle for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
Sorry, @rffontenelle and @StanFromIreland, I could not cleanly backport this to |
|
GH-158433 is a backport of this pull request to the 3.14 branch. |
|
GH-158434 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra whitespace in the second line causes Sphinx to consider not as part of the first line text. This is particularly problematic for translators, as these are treated as different strings (not as one in spite of being in two different lines).
Tested and confirmed it works by running
make venv gettextand then checking respective source string in the generated POT filebuild/gettext/builtins/threadsafety.pot.