gh-158215: Fix sqlite3 completer for schema names with a double quote - #158216
Open
Tony123-tech wants to merge 1 commit into
Open
Tony123-tech wants to merge 1 commit into
Tony123-tech wants to merge 1 commit into
Conversation
Tony123-tech
force-pushed
the
gh-158215-fix-sqlite3-completer-schema-quote
branch
from
September 26, 2026 04:39
8afa0c6 to
fef09a6
Compare
Member
There was a problem hiding this comment.
Please just add it to existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema name from PRAGMA database_list was interpolated directly
into SQL strings, so an attached database whose name contains a double
quote produced invalid SQL and _complete() raised OperationalError.
Quote the schema name as an SQL identifier, doubling embedded double
quotes, before interpolating it into the queries.