Skip to content

[3.14] gh-157983: Skip test for ctypes.util.find_library when ld is mold (GH-157984) - #158009

Merged
hugovk merged 2 commits into
python:3.14from
miss-islington:backport-dcaa311-3.14
Sep 24, 2026
Merged

hugovk merged 2 commits into
python:3.14from
miss-islington:backport-dcaa311-3.14

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

The mold linker does not support the -t option that
ctypes.util.find_library uses.
Since find_library is soft-deprecated and explicitly documented as
not expected to be updated for additional platforms and configurations,
we skip the test in the known failing case.
(cherry picked from commit dcaa311)

Co-authored-by: Petr Viktorin encukou@gmail.com

…ld (pythonGH-157984)

The `mold` linker does not support the `-t` option that
`ctypes.util.find_library` uses.
Since `find_library` is soft-deprecated and explicitly documented as
*not expected to be updated for additional platforms and configurations*,
we skip the test in the known failing case.
(cherry picked from commit dcaa311)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Comment thread Lib/test/test_ctypes/test_find.py Outdated
Comment on lines +93 to +95
# The mold linker is known to be incompatible with
# the soft-deprecated ctypes.util.find_library
# (which uses `ld -t`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# The mold linker is known to be incompatible with
# the soft-deprecated ctypes.util.find_library
# (which uses `ld -t`).
# The mold linker is known to be incompatible with
# ctypes.util.find_library. The function is
# documented as "Try to find a library..."
# and formally soft-deprecated in 3.15+. We
# we skip the test rather than try to fix it
# (which would risk breaking other unsupported
# platforms).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk, is this OK for 3.14?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is sensible.

@hugovk

hugovk commented Sep 23, 2026

Copy link
Copy Markdown
Member

Thank you!

@hugovk
hugovk merged commit 1b42680 into python:3.14 Sep 24, 2026
51 checks passed
@miss-islington
miss-islington deleted the backport-dcaa311-3.14 branch September 24, 2026 09:33
@hugovk hugovk added the needs backport to 3.13 bugs and security fixes label Sep 24, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @miss-islington and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1b42680b3a370e8466d3b8ea17ca598e98066b88 3.13

@bedevere-app

bedevere-app Bot commented Sep 24, 2026

Copy link
Copy Markdown

GH-158064 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 24, 2026
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 24, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @miss-islington and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1b42680b3a370e8466d3b8ea17ca598e98066b88 3.11

@miss-islington-app

Copy link
Copy Markdown

Sorry, @miss-islington and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1b42680b3a370e8466d3b8ea17ca598e98066b88 3.13

@miss-islington-app

Copy link
Copy Markdown

Sorry, @miss-islington and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1b42680b3a370e8466d3b8ea17ca598e98066b88 3.12

@hugovk

hugovk commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

No backport for 3.10 needed as there's no riscv64 Ubuntu buildbot for 3.10.

@bedevere-app

bedevere-app Bot commented Sep 24, 2026

Copy link
Copy Markdown

GH-158065 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 24, 2026
@bedevere-app

bedevere-app Bot commented Sep 24, 2026

Copy link
Copy Markdown

GH-158066 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 24, 2026
@hugovk hugovk removed the needs backport to 3.13 bugs and security fixes label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants