Skip to content

gh-75487: Do not save a truncated number when an int entry is blanked in IDLE Settings - #157680

Merged
terryjreedy merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-75487-blank-int-entry
Sep 22, 2026
Merged

terryjreedy merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-75487-blank-int-entry

Conversation

@serhiy-storchaka

Copy link
Copy Markdown
Member

The value of an entry is recorded on every keystroke, so blanking "80" with the Backspace key left "8" to be saved. Blanking an entry now forgets the recorded value, so that the saved value is kept (a blank itself is already not saved since #152743).

🤖 Generated with Claude Code

…lanked in IDLE Settings

The value is recorded on every keystroke, so blanking "80" with the
Backspace key left "8" to be saved.  Blanking an entry now forgets the
recorded value, so that the saved value is kept.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 17, 2026
@terryjreedy

terryjreedy commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

I manually verified bug -- last digit erased when blanking is saved after OK -- and fix -- OK when blank leave old value.
EDIT: in addition to reviewing patch ;-).

@terryjreedy
terryjreedy merged commit f67c51f into python:main Sep 22, 2026
59 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

GH-157962 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Sep 22, 2026
@bedevere-app

bedevere-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

GH-157963 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 22, 2026
@bedevere-app

bedevere-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

GH-157964 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 22, 2026
terryjreedy pushed a commit that referenced this pull request Sep 22, 2026
…blanked in IDLE Settings (GH-157680) (#157964)

The value is recorded on every keystroke, so blanking "80" with the
Backspace key left "8" to be saved.  Blanking an entry now forgets the
recorded value, so that the saved value is kept.
(cherry picked from commit f67c51f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy pushed a commit that referenced this pull request Sep 22, 2026
…blanked in IDLE Settings (GH-157680) (#157963)

The value is recorded on every keystroke, so blanking "80" with the
Backspace key left "8" to be saved.  Blanking an entry now forgets the
recorded value, so that the saved value is kept.
(cherry picked from commit f67c51f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants