gh-153569: consolidate tokenizer input, layout, and diagnostics - #157055
Merged
pablogsal merged 6 commits intoSep 24, 2026
Merged
Conversation
This was referenced Sep 7, 2026
pablogsal
force-pushed
the
gh-153569-tokenizer-input-diagnostics
branch
2 times, most recently
from
September 12, 2026 13:37
11383f5 to
d03c162
Compare
pablogsal
marked this pull request as ready for review
September 12, 2026 17:51
pablogsal
requested review from
a team,
AA-Turner,
emmatyping,
ericsnowcurrently,
erlend-aasland,
itamaro and
lysnikolaou
as code owners
September 12, 2026 17:51
pablogsal
force-pushed
the
gh-153569-tokenizer-input-diagnostics
branch
from
September 24, 2026 15:52
d03c162 to
9016f1d
Compare
pablogsal
enabled auto-merge (squash)
September 24, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put decoded input ownership and interactive-input control in the reader, and group indentation and logical-line handling in the layout state.
Record diagnostic locations and source spans separately from the scanning cursor. Parser consumers use the tokenizer snapshot and view APIs, including the diagnostic context. Remove the unused cursor and source lookup APIs, duplicate accessors, obsolete state, and dead lexer header and debug helper.
Part of gh-153569. Last PR in the stack; the preceding PRs have landed.