gh-155496: Use Argument Clinic for more functions of the _thread module - #155514
Merged
Merged
Conversation
serhiy-storchaka
marked this pull request as ready for review
August 14, 2026 05:17
# Conflicts: # Include/internal/pycore_global_objects_fini_generated.h
serhiy-storchaka
enabled auto-merge (squash)
September 24, 2026 17:23
# Conflicts: # Include/internal/pycore_unicodeobject_generated.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert all functions and methods of the
_threadmodule, except thestart_new(),allocate()andexit_thread()aliases, which Argument Clinic cannot express.The type of the
argsandkwargsarguments ofstart_new_thread()is now checked by the generated code, therefore the error message for a wrong type is the standard one.