Repository navigation
gh-152692: Fix annotationlib.type_repr() for bound built-in methods - #152693
Conversation
…hods type_repr() returned a string naming a nonexistent module None -- e.g. type_repr([].append) == 'None.list.append' -- for bound built-in methods, whose __module__ is None. Return the qualified name when __module__ is None, as already done for the "builtins" module.
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
This is incorrect for extension classes that are not in the builtins module.
>>> print(datetime.datetime.now().isoformat.__module__)
None
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Good catch. When I have made the requested changes; please review again |
|
Thanks for making the requested changes! @sobolevn, @JelleZijlstra: please review the changes made to this pull request. |
JelleZijlstra
added
needs backport to 3.14
|
This PR is stale because it has been open for 90 days with no activity. |
|
Thanks @tonghuaroot for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-159280 is a backport of this pull request to the 3.15 branch. |
|
GH-159281 is a backport of this pull request to the 3.14 branch. |
…thods (GH-152693) (GH-159280) type_repr() returned a string naming a nonexistent module None -- e.g. type_repr([].append) == 'None.list.append' -- for bound built-in methods, whose __module__ is None. Return the qualified name when __module__ is None, as already done for the "builtins" module. (cherry picked from commit 6979003) Co-authored-by: tonghuaroot (童话) <tonghuaroot@gmail.com>
…thods (GH-152693) (#159281) gh-152692: Fix annotationlib.type_repr() for bound built-in methods (GH-152693) type_repr() returned a string naming a nonexistent module None -- e.g. type_repr([].append) == 'None.list.append' -- for bound built-in methods, whose __module__ is None. Return the qualified name when __module__ is None, as already done for the "builtins" module. (cherry picked from commit 6979003) Co-authored-by: tonghuaroot (童话) <tonghuaroot@gmail.com>
3 participants
type_repr()returned a string naming a nonexistent moduleNone-- e.g.type_repr([].append) == 'None.list.append'-- for bound built-in methods,whose
__module__isNone.Return the qualified name when
__module__isNone, as already done for the"builtins"module. This also covers C-accelerator functions such asrandom.random.annotations_to_stringandget_annotations(format=Format.STRING)are fixed transitively when anannotation value is such a method.