SpooledTemporaryFile.__iter__ is not transparent to rollover

BPO	42868

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-01-08.14:46:35.069>
labels = ['type-bug', 'library', '3.10']
title = 'SpooledTemporaryFile.__iter__ is not transparent to rollover'
updated_at = <Date 2021-01-08.14:46:35.069>
user = 'https://bugs.python.org/jinohkangkr'

bugs.python.org fields:

activity = <Date 2021-01-08.14:46:35.069>
actor = 'jinoh.kang.kr'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-01-08.14:46:35.069>
creator = 'jinoh.kang.kr'
dependencies = []
files = []
hgrepos = []
issue_num = 42868
keywords = []
message_count = 1.0
messages = ['384674']
nosy_count = 1.0
nosy_names = ['jinoh.kang.kr']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42868'
versions = ['Python 3.10']

Linked PRs

gh-87034: Keep SpooledTemporaryFile iterators valid across rollover #159342

In tempfile, SpooledTemporaryFile.__iter__ is defined as follows:

    # file protocol
    def __iter__(self):
        return self._file.__iter__()

A rollover would switch the underlying _file object from a BytesIO to a TemporaryFile, thereby leaving the original iterator stale.

This may be fixed by:

    def __iter__(self):
        while True:
            line = self._file.readline()
            if not line:
                break
            yield line

Or perhaps:

    def __iter__(self):
        while True:
            file = self._file
            for line in file:
                yield line
                if file is not self._file:
                    break
            else:
                break

Navigation Menu

Repository navigation

SpooledTemporaryFile.iter is not transparent to rollover #87034

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

SpooledTemporaryFile.__iter__ is not transparent to rollover #87034

Description

Linked PRs

Activity

jinohkangkr commented on Jan 8, 2021

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

SpooledTemporaryFile.iter is not transparent to rollover #87034