Repository navigation
Honor explicit zero density in material mixtures - #143
Merged
pkienzle merged 2 commits intoOct 23, 2026
Merged
Conversation
pkienzle
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mix_by_weightandmix_by_volumeignoredensity=0andnatural_density=0, retaining a computed positive density. Their scattering results therefore remain nonzero for a requested vacuum.Distinguish omitted overrides from zero. Handle zero natural density without evaluating an undefined isotope mass ratio for empty formulas, including zero-quantity mixtures.
Fourteen regressions pass, including ten that fail before. Full tests, doctests and mypy pass on Python 3.10 and 3.12 (131 checks each); the configured strict HTML build passes. Independent material-mixture equations verify the density, composition and downstream scattering results.
The implementation and validation were AI-prepared.