Conversation
- docs/api.rst: drop duplicated 'from' in exception namespace sentence - src/attr/_make.py: drop duplicated 'picked' in alias auto-generation comment The attrs CONTRIBUTING guide encourages submitting typos and grammar fixes, so these minor word-repetition fixes are welcome. They are isolated to comments and prose, so no tests or behavior changes are required.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two minor word-repetition typos in the project:
docs/api.rst:105- drop duplicatedfromin the exception namespace sentence: "it doesn't matter from from which namespace they've been raised".src/attr/_make.py:2652- drop duplicatedpickedin the alias auto-generation comment: "if the user picked picked the old one".Why
The
attrsCONTRIBUTING guide explicitly encourages drive-by typo and grammar fixes:These changes are isolated to a doc paragraph and one inline comment, so they don't alter any runtime behavior and don't require new tests or coverage work.
Diff