Skip to content

Preserve the string dimension for imported NC_STRING variables - #151

Draft
f-brinkmann with Copilot wants to merge 2 commits into
hot/fix_character_encodingfrom
copilot/fix-code-for-review-comment
Draft

Preserve the string dimension for imported NC_STRING variables#151
f-brinkmann with Copilot wants to merge 2 commits into
hot/fix_character_encodingfrom
copilot/fix-code-for-review-comment

Conversation

Copilot AI commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Custom NC_STRING variables kept their original dimensions (for example, M) when imported, omitting S from string-length calculations and risking failed or truncated write-back.

  • Import metadata: Add the S axis for custom NC_STRING variables in both read_sofa and SofaStream.
  • Round-trip coverage: Check the imported dimensions and preserve the string value after writing and rereading.

For example, a variable stored with dimension M is represented internally as MS after import.

@f-brinkmann
f-brinkmann added this pull request to stack #152 October 30, 2026 12:52
@f-brinkmann
Normalize NC_STRING custom dimensions
f907f97 
Co-authored-by: f-brinkmann <58219902+f-brinkmann@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code based on review comment for pull request 149 Preserve the string dimension for imported NC_STRING variables Oct 30, 2026
Copilot AI requested a review from f-brinkmann October 30, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f-brinkmann f-brinkmann Awaiting requested review from f-brinkmann

At least 2 approving reviews are required to merge this pull request.

Assignees

@f-brinkmann f-brinkmann

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@f-brinkmann