Repository navigation
Fix ruff - #150
Open
f-brinkmann wants to merge 1 commit into
Open
Fix ruff#150f-brinkmann wants to merge 1 commit into
f-brinkmann wants to merge 1 commit into
Conversation
artpelling
reviewed
Oct 25, 2026
| # dimensions than defined and inspect should still work) | ||
| shape_verbose = "(" | ||
| for s, d in zip(shape, dimension): | ||
| for s, d in zip(shape, dimension, strict=False): |
Member
Author
There was a problem hiding this comment.
See comment righ above :) It's a user friendly way to make inspect work on sofa files that may have become invalid after an edit. This will be raised as an error in verify with an understandable error message.
ahms5
reviewed
Oct 30, 2026
| # allow `zip()` without passing the `strict` parameter for git submodule that | ||
| # is maintained in https://github.com/pyfar/sofa_conventions | ||
| "sofar/sofa_conventions/*" = [ | ||
| "B905", |
Member
There was a problem hiding this comment.
maybe it is better to add this to ruff exclude in line 78, as this is not in our hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes none, requires #149
Changes proposed in this pull request:
Fixes ruff that failed due to a ruff update. I tend to not add a histroy enrtry for this.