Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
None; reproduced on current
main.Checklist
Please explain your changes below.
rollchecks coordinate capacity usinga.shape + shift. Tuple inputs concatenate rather than add, allowing coordinate overflow: auint8COO with shape(255, 2)and a nonzero value at(254, 1)rolled by(2, 0)along(0, 1)incorrectly places it at(0, 1)instead of(1, 1). Array shifts can also check unrelated dimensions when axes are reordered.Check the possible shifted coordinate range for each selected axis, retaining the existing requirement to use a wider coordinate dtype for unsafe shifts. Safe boundary shifts and empty axes remain supported. The actual coordinate arithmetic and casting behavior are unchanged.
Added 43 cases for signed/unsigned bounds, tuple/list/array shifts, axis order, safe shifts and empty axes. All 114 roll tests pass. The full Numba-backend suite and module doctests report 6,938 passed, 1 skipped, 96 xfailed and 61 xpassed. Repository hooks and wheel build pass. Other backends and minimum-dependency environments were not run locally.
Prepared with OpenAI Codex.