Repository navigation
fix: canonicalize response header names before lookup - #561
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response header names keep their wire case and
headerValueis a plain map read, so the gzip check intoHTTPResponseand the redirect lookup indoonly match Title case. With a server that answerscontent-encoding: gzip,DoRawWithOptionsreturns the 46 byte gzip stream rather than the 21 byte body, and a lowercaselocationfails with "failed to parse url got empty input" instead of following the 302.Canonicalizing in
fromHeaderscovers both, andresp.Header.Getworks again. Request writing is untouched; sending raw bytes is the point here.go test -race ./...passes.