Repository navigation
feat: add option to follow only same-host redirects - #557
Merged
dwisiswant0 merged 1 commit intoNov 4, 2026
Merged
dwisiswant0 merged 1 commit into
dwisiswant0 merged 1 commit into
Conversation
With redirects on, the client followed a 3xx to whatever host and scheme the Location header named and resent the caller's headers, Authorization included. Nothing in Options could restrict that, so callers that want same-host redirects, such as nuclei's host-redirects and httpx's -follow-host-redirects, could only pick all redirects or none on the rawhttp path. Options.FollowHostRedirects follows a redirect only when the next request would connect to the same protocol and host:port as the current one. Otherwise do returns the redirect response unread. The check goes through dialTarget, the helper do now uses to choose the connection, so it compares exactly what would be dialed. Hosts must match byte for byte, because Unicode case folding maps some distinct hostnames, such as "ſecret.com", onto ASCII ones. As with the host-redirect options in nuclei and httpx, setting it also enables following when FollowRedirects is false. Closes: #556 Signed-off-by: Dwi Siswanto <git@dw1.io>
Mzack9999
approved these changes
Nov 4, 2026
dwisiswant0
deleted the
dwisiswant0/feat/add-option-to-follow-only-same-host-redirects
branch
November 4, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With redirects on, the client followed a 3xx to whatever host and
scheme the Location header named and resent the caller's headers,
Authorization included. Nothing in Options could restrict that, so
callers that want same-host redirects, such as nuclei's host-redirects
and httpx's -follow-host-redirects, could only pick all redirects or
none on the rawhttp path.
Options.FollowHostRedirects follows a redirect only when the next
request would connect to the same protocol and host:port as the
current one. Otherwise do returns the redirect response unread. The
check goes through dialTarget, the helper do now uses to choose the
connection, so it compares exactly what would be dialed. Hosts must
match byte for byte, because Unicode case folding maps some distinct
hostnames, such as "ſecret.com", onto ASCII ones. As with the
host-redirect options in nuclei and httpx, setting it also enables
following when FollowRedirects is false.
Closes: #556