Repository navigation
fix: dispatch payment submitted event for google pay and apple pay in dc - #281
Merged
Merged
Conversation
|
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The wallet event behavior is correctly implemented and covered by focused tests.
0 open findings
What changed in this PR
Adds payment-submitted events for Dynamic Checkout wallet payments.
Changes:
- Dispatches submitted events for approved Google Pay and Apple Pay payments.
- Adds wallet event payload and ordering tests.
- Extends the test namespace loader with wallet clients.
| File | Description |
|---|---|
src/dynamic-checkout/clients/google-pay.ts |
Dispatches the event before tokenization. |
src/dynamic-checkout/clients/apple-pay.ts |
Dispatches the event upon authorization. |
test/dynamic-checkout/wallet-events.test.ts |
Tests wallet event behavior and payloads. |
test/support/loadNamespace.ts |
Loads wallet clients in tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mateusz-walesiak-cko
previously approved these changes
Oct 9, 2026
This reverts commit 07d29ac.
mateusz-walesiak-cko
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dynamic Checkout never fired
processout_dynamic_checkout_payment_submittedfor Google Pay or Apple Pay, so merchants listening for it (e.g. CAT) couldn't tell a wallet payment was in progress. Every other payment method already fires it.Changes
onpaymentauthorizedPostprocess), just before the existingapple_pay_authorized_post_processevent.payment_method_name:google_pay/apple_pay, display name from the invoice).wallet-events.test.tsand extended the test loader with the wallet clients. The new tests fail onmasterand pass with this fix.Additional Context