Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The unconditional alias breaks compatibility with RtMidi 4.0.0, still fetched by default on Windows.
1 open issue
What changed in this PR
Addresses the RtMidi namespace conflict reported in #582 when compiling the audio output code on macOS.
Changes:
- Forward-declares
RtMidiOutinrt::midiand adds a global alias.
| File | Description |
|---|---|
| source/audio/midioutputdevice.h | Updates the RtMidi type declaration for the namespaced API. |
Review effort: Balanced
Comment on lines
+36
to
+37
| namespace rt { namespace midi { class RtMidiOut; } } | ||
| using RtMidiOut = rt::midi::RtMidiOut; |
Contributor
Author
There was a problem hiding this comment.
RtMidi 4.0.0 is from Apr 18, 2019 so we can change the minimum requirement to RtMidi 6.0.0 from 2023.
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fixes Issue(s)
#582