Repository navigation
Conversation
…, default 8). - Dynamically resize toolbox buttons and reorganize the grid according to the selected column count. - Add inner padding to tool button icons to prevent glyph clipping at button boundaries. - Initialize toolbox 25% of the main window width at startup.
There was a problem hiding this comment.
🟡 Changes recommended
The startup resize overrides the toolbox width restored from the user’s saved window state.
1 open finding
What changed in this PR
Adds configurable toolbox icon sizing by varying icons per row and resizing the dock layout dynamically.
Changes:
- Adds a persisted 4–8 icons-per-row preference.
- Reflows and resizes toolbox buttons with scrolling support.
- Sets an initial toolbox width based on the main window.
| File | Description |
|---|---|
source/widgets/toolbox/toolbox.ui |
Removes the fixed minimum size. |
source/widgets/toolbox/toolbox.h |
Adds resizing and grid configuration APIs. |
source/widgets/toolbox/toolbox.cpp |
Implements dynamic layout, sizing, and scrolling. |
source/dialogs/preferencesdialog.ui |
Adds the column-count slider. |
source/dialogs/preferencesdialog.cpp |
Loads and saves the preference. |
source/app/settings.h |
Declares the new setting. |
source/app/settings.cpp |
Defines its default value. |
source/app/powertabeditor.h |
Tracks toolbox-width initialization. |
source/app/powertabeditor.cpp |
Applies settings and initializes dock width. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
not yet finished... |
toolbox width is saved in settings
|
It should be good now |
|
I'm not sure if I like the dynamic scaling, since it gets really large / small (e.g. if you have a really big monitor, the default sizing can make the icons huge). |
…erence - Updated the minimum required version of CMake to 3.24 for RtMidi 6 support - Updated the minimum required version of `RtMidi` to 6.0.0 - The toolbox now uses 15% of the window width, with icon columns adapting to fill each row
|
ok. You can have a look at this commit now. I change some files to solve the rtmidi #582 |
Description of Change(s)
Fixes Issue(s)
#491