Repository navigation
Fix rest and vibrato positions - #577
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused rendering changes correctly address symbol alignment without introducing unresolved issues.
0 open findings
What changed in this PR
Corrects horizontal alignment of rests and tremolo-picking symbols with staff positions.
Changes:
- Accounts for bounding-rectangle offsets when centering symbols.
- Centers rests independently from augmentation dots.
- Aligns tremolo picking to standard position spacing.
| File | Description |
|---|---|
source/painters/systemrenderer.cpp |
Updates symbol-centering and rest rendering logic. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
Looks good, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #542 and #540
I think it will be ok this time !