Repository navigation
[8.x] Write the generated evolution script to absolute evolution paths, and explain projects without Play's layout - #932
Merged
Conversation
With an absolute `play.evolutions[.db.<name>].path`, Play's evolutions read the scripts from that path as it is, but Play Ebean resolved it relative to the application's root folder, like any other path. So it wrote the script to e.g. `<root>/opt/migrations/default/1.sql` instead of `/opt/migrations/default/1.sql`, where Play didn't find it, and it didn't see a hand-written script there. Play Ebean now resolves the path like Play's evolutions do. The new test checks for each kind of path that Play applies the generated script, and that a hand-written script in an absolute folder stays untouched.
…ay's layout Play Ebean follows the location of the evolution scripts that Play's evolutions use. In a project that disables Play's layout, Play still looks for the scripts in `conf` first, but doesn't package that folder, so the generated script is missing in production, and it takes precedence over the user's script in `src/main/resources` in dev and test mode. The docs show how to generate the script into the resources instead, or to turn off generating it.
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8.x.