Repository navigation
ci: drop GCP login and GCP KMS / GlobalSign secrets - #112
Open
mike-ainsel wants to merge 1 commit into
Open
mike-ainsel wants to merge 1 commit into
mike-ainsel wants to merge 1 commit into
Conversation
Windows binaries are signed with Azure Trusted Signing in milaboratory/github-ci windows-sign, and this repo publishes with plain npm publish, so nothing uses the GCP login or the GCP KMS / GlobalSign secrets any more.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the GCP / GlobalSign settings from the build. Nothing in this repo uses them any more.
windows-signin milaboratory/github-ci signs Windows binaries with Azure Trusted Signing only (windows-sign: sign with Azure Trusted Signing, drop GCP milaboratory/github-ci#212, on v4 and v4-beta); the GlobalSign certificate behind the GCP HSM key has expired. This repo's Azure federated credential is in milaboratory/infrastructure#463 (applied).gcloud-kms-sign, which this repo never calls (it publishes with plainnpm publish). That login now fails withIAM_PERMISSION_DENIED(seen in runenv-r-lineage-trees run 37481616710) and skips the publish; node-matrix: drop GCP login from the npm publish job milaboratory/github-ci#214 removes it fromnode-matrixon v4-beta, #215 promotes it to v4.Changes
gcp-login-enable: true(where set).WIN_SIGN_CERTandGCP_KMS_*secrets passed to the reusable workflow.The reusable workflows still declare these inputs and secrets, so this PR and the shared CI can merge in any order. Merging triggers a build on
main; with an unchanged version, publishing is skipped as before.The PR appears safe to merge, with no actionable issue established.
Summary
Removes the Windows certificate and five GCP KMS secrets passed by
.github/workflows/build.yamlto the shared build workflow.Important touched terms; no code types changed:
WIN_SIGN_CERT: The Windows signing certificate supplied to the shared workflow. Its mapping fromWIN_CODE_SIGN_CHAINis removed.GCP_KMS_WORKLOAD_IDENTITY_PROVIDER: The provider used to obtain Google Cloud credentials through workload identity. Its secret mapping is removed.GCP_KMS_SERVICE_ACCOUNT: The Google Cloud account used for KMS access. Its secret mapping is removed.GCP_KMS_LOCATION: The location containing the KMS key ring. Its secret mapping is removed.GCP_KMS_KEYRING: The KMS key ring containing the signing key. Its mapping fromGCP_SOFTWARE_KMS_KEYRINGis removed.GCP_KMS_KEY_NAME: The name of the KMS signing key. Its mapping fromGCP_SOFTWARE_KMS_KEY_NAMEis removed.Reviews (1) · Last reviewed commit: "ci: drop GCP login and GCP KMS / GlobalS..." · Reviewed by Greptile