Conversation
The panel in TiKV-Details is named "Max gap of resolved-ts". The same name is used in grafana-tikv-dashboard.md.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @sary8. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingcap/docs/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe troubleshooting example renames “Max Resolved TS gap” to “Max gap of resolved-ts” in the dashboard instructions and image alt text. The dashboard link and image path remain unchanged. ChangesStale Read Documentation
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other · Severity of issue fixed: Medium 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added, or deleted? (Required)
troubleshoot-stale-read.mdrefers to the panel as Max Resolved TS gap, but the current panel name is Max gap of resolved-ts (tikv_details.dashboard.py#L9052).grafana-tikv-dashboard.mdalready uses the current name.Update the panel name and the image alt text. The screenshot itself still shows the old name.
Fixes #23817.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit