Skip to content

keywords: add seven missing non-reserved keywords - #23911

Open
sary8 wants to merge 1 commit into
pingcap:masterfrom
sary8:keywords/add-missing-unreserved-keywords
Open

sary8 wants to merge 1 commit into
pingcap:masterfrom
sary8:keywords/add-missing-unreserved-keywords

Conversation

@sary8

@sary8 sary8 commented Sep 20, 2026

Copy link
Copy Markdown

What is changed, added, or deleted? (Required)

Add the ALERT, AUTO, FAST, IMMEDIATE, MATERIALIZED, OPERATE, and TRANSITIONS non-reserved keywords to keywords.md so it matches the current TiDB parser. All seven are defined as UnReservedKeyword in pkg/parser/parser.y, and scripts/check-keywords.py passes with them added.

Fixes #23846, closes #23750, and closes #23670. The last two are earlier runs of the same weekly check.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

None of the seven keywords is in the release-8.5 parser, and the weekly check reports that branch as passing, so no cherry-pick label is added.

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated the TiDB keyword reference with seven additional keywords: ALERT, AUTO, FAST, IMMEDIATE, MATERIALIZED, OPERATE, and TRANSITIONS.
    • Added the keywords in alphabetical order without reserved-word markers.

Add the seven UnReservedKeyword tokens that scripts/check-keywords.py
reports as missing on master: ALERT, AUTO, FAST, IMMEDIATE, MATERIALIZED,
OPERATE, and TRANSITIONS.

Each entry is inserted in its alphabetical position and left unmarked,
since all seven are alternatives of the UnReservedKeyword rule in
pkg/parser/parser.y.
@ti-chi-bot

ti-chi-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Sep 20, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

Hi @sary8. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2026
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a2061511-4b2e-487d-b15b-d77b87dd51b9

📥 Commits

Reviewing files that changed from the base of the PR and between f9f08f3 and 4f01f16.

📒 Files selected for processing (1)
  • keywords.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The TiDB keyword list now includes ALERT, AUTO, FAST, IMMEDIATE, MATERIALIZED, OPERATE, and TRANSITIONS in alphabetical order under their corresponding letter sections.

Changes

Keyword documentation

Layer / File(s) Summary
Add missing keyword entries
keywords.md
Adds seven non-reserved keywords to the alphabetical keyword list without (R) or (R-Window) markers.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other · Severity of issue fixed: Low

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the addition of seven missing non-reserved keywords.
Description check ✅ Passed The description covers the required change, affected version, related links, AI involvement, and change-category checklist. It also explains why only the master branch is affected.
Linked Issues check ✅ Passed The changes satisfy the coding requirements in [#23846], [#23750], and [#23670]. keywords.md adds all seven reported UnReservedKeyword entries: ALERT, AUTO, FAST, IMMEDIATE, MATERIALIZED
Out of Scope Changes check ✅ Passed The PR changes only keywords.md and adds the seven keywords required by [#23846], [#23750], and [#23670]. No unrelated source, release-branch, or other documentation changes are reported.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weekly keywords check: mismatches found Weekly keywords check: mismatches found Weekly keywords check: mismatches found

1 participant