Repository navigation
ci: stop duplicate and outdated check runs - #4
Open
npmccallum wants to merge 1 commit into
Open
npmccallum wants to merge 1 commit into
npmccallum wants to merge 1 commit into
Conversation
A workflow is a file that tells GitHub which automatic checks to run and when. A branch is a named line of work in the repository, and the main branch is the shared branch that changes are merged into. A push means sending new commits up to GitHub. This workflow runs the checks for pull requests, for pushes to the main branch, and when someone starts it by hand. A push to any other branch does not start it, because the pull request for that branch already runs the same checks. GitHub lets a workflow give each run a group label, and only one run with the same label goes at a time. On the main branch, every run gets its own label, so no run there is ever stopped. Anywhere else, a newer run for the same pull request, or a newer run started by hand on the same branch, stops the older one. Fixes #3
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A workflow is a file that tells GitHub which automatic checks to run
and when. This change makes the checks workflow (the
ci.ymlfile thatruns the tests and other checks) run once for each update to a pull
request, and stop an older run when a newer one starts.
Fixes #3
Approach
A branch is a named line of work in the repository, and the main
branch is the shared branch that changes are merged into. A push means
sending new commits up to GitHub.
The checks workflow runs for pull requests, for pushes to the main
branch, and when someone starts it by hand. A push to any other branch
does not start it, because the pull request for that branch already
runs the same checks.
GitHub lets a workflow give each run a group label, and only one run
with the same label goes at a time. On the main branch, every run gets
its own label, so no run there is ever stopped. Anywhere else, a newer
run for the same pull request, or a newer run started by hand on the
same branch, stops the older one.
The group label settings are the same as in the open change
pichi-vm/burrow#5, which has not been merged
yet. Only
ci.ymlchanged. The docs workflow (thedocs.ymlfile thatbuilds the code documentation) and the list of checks and their names
were not touched.
Verification
ci.ymlordocs.yml.git diff --check(looks for stray spaces at line ends) found nothing.cargo fmt(checks code formatting) found nothing to change.cargo clippy(Rust's code-quality checker), with warnings treated as errors, gave no warnings.--all-targets --all-features, which builds and checks every part of the code and every optional feature.cargo test: 105 passed, 0 failed, 0 ignored. Running it with--ignoredfound no ignored tests to run.--ignored.cargo deny(checks the dependencies, meaning the outside Rust libraries, called crates, that this code uses) passed all four parts: known security advisories (advisories), banned or duplicate crates (bans), licenses, and allowed download sources (sources).--cfg docsrs(builds the docs the way docs.rs, the public Rust documentation site, does) with no errors.tests/data/regenerate.shgave no changes.fuzz_parse5,594,538 inputs,fuzz_overlay2,357,473, andfuzz_owned2,438,838.