Repository navigation
Stop publishing docs to GitHub Pages - #1
Merged
Merged
Conversation
Walk fixed-size u32 cells with as_chunks instead of chunks_exact. A short tail is still rejected by the multiple-of-four check. Use assert_ne! for a nonempty error Display check. Co-authored-by: Nathaniel McCallum <nathaniel@mccallum.life>
Keep building rustdoc on pushes to main so the docs still get checked. This repo no longer publishes them to GitHub Pages. Only pichi-vm.github.io publishes to pichi.dev. Co-authored-by: Nathaniel McCallum <nathaniel@mccallum.life>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo should not publish to GitHub Pages. Only the main site repo does that. The docs workflow still built rustdoc and then tried to publish it.
Approach
Keep the rustdoc build as a check. Remove the Pages deploy job, Pages write permissions, and the Pages artifact upload. Leave the concurrency group named for docs.
Verification