Repository navigation
Conversation
phper did not compile against PHP 8.6. The release renames or reshapes several symbols that bindgen exposes, and the build failed with 21 errors in the phper crate. ZEND_USER_FUNCTION, ZEND_EVAL_CODE and the ZEND_RESULT_CODE_* values became C23 enums, so bindgen now prefixes them with the enum name. They are aliased back in utils.rs, which leaves the call sites alone. zend_call_known_function became a static inline wrapper that bindgen cannot see, so 8.6 calls zend_call_known_function_ex directly. The zend_ini_* getters take a bool for "orig", handlers.offset is a size_t, and zend_function_entry.flags is a uint64_t. The HASH_KEY_IS_* gate tested for exactly 8.5, so 8.6 took the older branch. It now means 8.5 and later, which also keeps 8.7 working. Add an 8.6 row to the CI matrix. It is marked experimental, so a failure does not fail the run, until 8.6 reaches GA on 2026-11-19. Local runs pass on 7.0 to 8.6. ZTS and debug builds are untested. Assisted-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phper did not compile against PHP 8.6. The release renames or reshapes several symbols that bindgen exposes, and the build failed with 21 errors in the phper crate.
ZEND_USER_FUNCTION, ZEND_EVAL_CODE and the ZEND_RESULT_CODE_* values became C23 enums, so bindgen now prefixes them with the enum name. They are aliased back in utils.rs, which leaves the call sites alone. zend_call_known_function became a static inline wrapper that bindgen cannot see, so 8.6 calls zend_call_known_function_ex directly. The zend_ini_* getters take a bool for "orig", handlers.offset is a size_t, and zend_function_entry.flags is a uint64_t.
The HASH_KEY_IS_* gate tested for exactly 8.5, so 8.6 took the older branch. It now means 8.5 and later, which also keeps 8.7 working.
Add an 8.6 row to the CI matrix. It is marked experimental, so a failure does not fail the run, until 8.6 reaches GA on 2026-11-19. Local runs pass on 7.0 to 8.6. ZTS and debug builds are untested.
Assisted-By: Claude Code