Repository navigation
fix: pass log messages as an argument, not a format - #265
Merged
Merged
Conversation
output::log handed the message to php_error_docref1 as the format string. A message containing "%s" crashed the process, and "%%" was collapsed to "%". The macros take Rust format syntax, so authors had no reason to escape anything. Call php_error_docref with a "%s" format through a wrapper in php_wrapper.c. The function is a macro before PHP 7.4, so the wrapper keeps one code path for all versions. php_error_docref1 is removed in PHP 8.6, so this also clears one build error there. Assisted-By: Claude Code
brettmc
force-pushed
the
fix/log-format-string
branch
from
November 1, 2026 06:25
848e7da to
41db81c
Compare
jmjoy
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
output::log handed the message to php_error_docref1 as the format string. A message containing "%s" crashed the process, and "%%" was collapsed to "%". The macros take Rust format syntax, so authors had no reason to escape anything.
Call php_error_docref with a "%s" format through a wrapper in php_wrapper.c. The function is a macro before PHP 7.4, so the wrapper keeps one code path for all versions. php_error_docref1 is removed in PHP 8.6, so this also clears one build error there.
Assisted-By: Claude Code