Repository navigation
fix: wait for late iframes in withinFrame() - #326
Open
clarkewing wants to merge 2 commits into
Open
clarkewing wants to merge 2 commits into
clarkewing wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withinFrame()fails when the iframe is added to the page after load, which is, for example, how Stripe Checkout renders its payment form.frameLocator()looks the selector up once without waiting. If the iframe isn't there yet, it assumes the selector is a container and waits for<selector> >> iframe, an iframe inside the iframe, which can never match. On 5.x that ends in a timeout. On 4.x with Playwright 1.62+ it hangs forever.The fix waits for the selector to be attached before resolving the frame. Containers work as before.
Fixes pestphp/pest#1650. The
networkidlecall mentioned there isn't the cause:waitForLoadState()never sends its request (see #273).Tests cover late iframes (same and cross origin), a busy network, nested frames, late containers, and duplicate matches.