Repository navigation
fix: persist the port of the running playwright server - #321
Merged
Merged
Conversation
If playwright is already defined, do not try to persist again with a new port
MrPunyapal
approved these changes
Nov 18, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerManager::playwright()finds a new port and persists it on every call, even after the server has been created. The server keeps listening on its original port, so after a second call (for example fromBrowsableor the terminate hook) the persisted state points at a port nobody listens on, and each call opens a socket for nothing.This creates the server, and persists its host and port, only once.
Supersedes #169, rebased onto
5.xas requested by the maintainers; original work by @biinari. The other half of #169 (runningplaywright run-serverso that stopping it reaches node) is covered by #254.The added test fails on
5.x(the persisted port differs from the server's port) and passes with this change.composer testpasses locally.