Repository navigation
Conversation
The error check ran before the request-id check, so an error for an abandoned earlier request was thrown into the next command. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
PHPStan (isset.offset, level max) reports the error key as always present in the docblock shape, so the isset() guard for foreign responses fails the test:types step in the fork's CI. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors are thrown before the id check, so a late error for an abandoned request ends the next command. The loop already skips ordinary responses with another id; this applies the same rule to error responses.
Adds tests/Unit/Playwright/ClientForeignErrorTest.php:
Related: #247 (stale response ids), #266 (matching navigation response).
Downstream this shows up as flaky "interrupted by another navigation" failures.
🤖 Generated with Claude Code