Repository navigation
test(skill): retire the paragraph check against the pre-split skill - #42
Merged
Merged
Conversation
The check that every paragraph of the frozen pre-split SKILL.md still appears in the split skill guarded one refactor (#41). Since then it makes every ordinary edit of the skill register a rewrite entry. It goes with its fixture; the structural checks stay: 500 lines, CORE_BYTES, the description length, reference paths that resolve, contents lists, and a dispatch row for every /km verb. The verb check now reads the skill's own files instead of the baseline, so approve, doctor, lint, pr and review, which the README does not name, stay covered. A row counts only where the verb opens a code span or a quoted phrase in the table, not where it is a word in another row's text, and skill_smoke shows the check fails without the review/approve row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tests/skill_inventory.pychecked that every paragraph of the frozen pre-split SKILL.md (tests/fixtures/skill-baseline.md) still appears in the split skill, with aREWRITESand aREWRAPPEDlist for every deliberate change. That was a one-off guard for the split in #41. Since then every ordinary edit of the skill has to register itself there, and the re-wrap of the Markdown planned next would trip it on every paragraph.What changes
REWRITES,REWRAPPED,--baselineand the fixture go. The atoms were computed from the baseline too, so they go with it.CORE_BYTES = 12000, description <= 1024 characters, every reference file named by its full path and every such path resolving, a## Contentslist in a reference file over 100 lines, a dispatch row for every/kmverb,helpdefined.approve,doctor,lint,prandreview, which the README does not name, stay covered.`review <doc>`,"check my setup"). Before, a bare word anywhere in the table passed, so removing the review/approve row went unnoticed because "review a brain PR" sits in theprrow.skill_smoke.shgains a case: a copy of the skill without that row must fail forapproveandreview. It fails with the old match (checked).evals/README.mdno longer describe the retired check. CI runsskill_smoke.shas before, nothing to change there.Reviews
/simplify(reuse, simplification, efficiency, altitude): clean, no edits. Two cosmetic notes left: the script keeps its nameskill_inventory.py(renaming touches README, CI and the smoke test for no behaviour), and the edited README line is longer than its hard-wrapped neighbours (the re-wrap PR makes the paragraph one line anyway)./code-review, applied: the bare-word row match and the missing negative case (both above). Not applied:/km <word>in a reference file now becomes a required row. The failure names the verb, and the fix is a rewording or a row; acceptable.fileskeyed by display name could be simplified: left, it is unchanged code.All smoke tests pass locally. No change under
skills/km/, so the plugin evals do not apply.