Repository navigation
test(cli): the commands that never hand over to the pinned km run the km that was started - #40
Merged
Merged
Conversation
pasrom
force-pushed
the
test/upgrade-runs-this-km
branch
from
November 6, 2026 21:01
a31a08b to
551aa4a
Compare
… km that was started upgrade, init, doctor, list and sync are in NO_PIN_CHECK. The smoke test now checks each of them in a brain pinned to an older km: exit 0, the runner is not called, no 'running that one' notice. The cli docstring and the skill name these commands, so nobody adds KM_LOCAL=1 to km upgrade again.
pasrom
force-pushed
the
test/upgrade-runs-this-km
branch
from
November 6, 2026 21:03
551aa4a to
d2176ef
Compare
pasrom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A note said that
uvx --from git+https://github.com/pasrom/km@<tag> km upgradeneedsKM_LOCAL=1, because otherwise the brain's older pinned km would run instead. That is not so:upgrade(with init, doctor, list and sync) is inNO_PIN_CHECKand never hands over to the pinned km.Checked by hand: a brain pinned to v1.2.0,
uvx --from ...@v1.8.1 km upgradewithout KM_LOCAL ran v1.8.1 and moved every pin to v1.8.1, with no "running that one" line.Changes:
km <cmd> --root ... --helpmust exit 0, must not call the runner and must not print "running that one". The failure line shows rc, the runner arguments and the output.Evidence: team_smoke 119 passed, 0 failed. Mutation check: with
doctorremoved from NO_PIN_CHECK the doctor case fails (118/1), restored afterwards; earlier, withupgraderemoved, the upgrade case failed.Reviews actually run: /simplify (one reviewer, all four angles): clean, one suggestion applied (check the exit code). /code-review (medium): no correctness bug, 5 findings; applied: cover the whole NO_PIN_CHECK set, show rc and output in the failure line, assert no "running that one" notice, name the commands in the docs. Not applied: a real upgrade on a throwaway copy (the existing case "upgrade moves older pins to this km" covers that a real upgrade moves the pins).