Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Hardens the CI workflow by passing the resolved major tag through an environment variable instead of shell interpolation.
Changes:
- Adds
TAG_NAMEto the step environment. - Preserves existing validation and tag-update behavior.
| File | Description |
|---|---|
.github/workflows/ci.update-major-version-tag.yaml |
Uses an environment variable for safer tag handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cvscarlos
marked this pull request as ready for review
October 2, 2026 15:31
Contributor
|
@cvscarlos did you test this by pointing your target workflow to this branch and running it? We need to confirm it's not braking things before merging. |
cvscarlos
marked this pull request as draft
October 5, 2026 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
ci.update-major-version-tag.yamlby reading the resolved tag from the step'senv:instead of expanding${{ ... }}inside therun:script.This follows GitHub's recommendation for inline scripts: https://docs.github.com/en/actions/reference/security/secure-use#use-an-intermediate-environment-variable