Repository navigation
fix(docs): let the Vercel build install what the web components import - #242
Merged
Merged
Conversation
The site is built on Vercel from apps/docs, and an install run from there brings only the docs app's own dependencies. Its pages import the web components' source by path, and that source imports tailwind-variants, which the docs app had never declared. CI installs every workspace from the root, so it was there in CI and missing on Vercel: the first deploy with the web collection failed at "Module not found: tailwind-variants" with every check green. The docs app now depends on panelui-web by name, which brings that package's dependencies with it. Checked by cloning the repository fresh, installing from apps/docs and building, which is what Vercel does. A contract test keeps the dependency there, and checks that the web package declares everything its source imports. CLAUDE.md says how the two installs differ and how to reproduce Vercel's. The lockfile gains one line, the new edge. No version moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main change: allowing the Vercel docs build to install the web components dependency. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
apps/docsnow depends onpanelui-webby name.Why
The production deploy of
mainafter #241 failed on Vercel:Vercel builds from
apps/docs, andnpm installrun inside a workspace brings only that workspace's dependencies. The docs pages import the web components' source by path, and that source importstailwind-variants, which the docs app never declared. CI runsnpm ciat the root, which brings everything, so every check was green.Type of change
How it was tested
npm installinapps/docs:tailwind-variantswas missing before this change and present after it.npm run buildinapps/docspasses, which is what Vercel runs.npm test(819 pass, one new),npm run typecheck,npm run docs:generateleaves no diff.A contract test now holds the dependency in place and checks that
packages/web/package.jsondeclares everything its source imports. The lockfile gains one line; no version moved.🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation
Tests