Correct numerical findings and add reproduction tools - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The numerical findings prescribed an ambiguous far-field threshold, an incomplete lossy-line calculation, and a skin-depth warning that could miss under-resolved elements. Correct those recommendations and distinguish mesh sensitivity from demonstrated error against a converged reference.
Add a C cancellation harness and a standard-library Python script that reproduce the frequency and mesh tables using temporary inputs. The calculator's runtime behavior is unchanged.
Validation:
-O2 -Walland reproduced the cancellation table.git diff --checkpassed.