Fix dielectric attenuation, input validation, and header rebuilds - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calculator could report excessive dielectric attenuation and successfully calculate a different conductor configuration after rejecting an invalid conductor. Malformed numeric inputs could also produce NaN results or silently change frequency (
30MHzbecame 30 Hz).This change corrects the dielectric filling factor and attenuation coefficient, aborts on conductor validation errors, and requires finite numeric values with no trailing text. Mesh counts must be integers within their supported ranges. It also adds generated header dependencies to the Makefile and corrects the dB/m-to-Np/m explanation for gamma.
Regression tests build and run the C executable in temporary directories, cover all five findings, and check valid-input and lossless-substrate behavior. CI now runs the full test suite, and the README documents the corrected formula and input requirements.
Validation:
python3 -m pytest -q: 56 passed after fixes.make -B: full rebuild succeeded.make check-z0: agreement within 0.03% of the Hammerstad-Jensen reference.git diff --check: passed.