Repository navigation
Exit when serving stops, instead of waiting on the update checker - #25
Merged
Merged
Conversation
After the display pipeline failed the server asked itself to quit and closed the port, but the process never exited: dropping the runtime waited for the update checker, a blocking task that sleeps for hours. A stack sample of the stuck agent showed the main thread there. launchd restarts the agent only once the process is gone, so RDP stayed down until the process was killed by hand. The runtime now gives background work two seconds on shutdown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
org-event
enabled auto-merge (rebase)
November 6, 2026 12:31
…ade to. It comes through sspi's async-dnssd, and the advisory is about maintenance, not a vulnerability. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
On the Mac mini the client's virtual display went away: CoreGraphics error 1014 while stopping the mirroring, then
CGVirtualDisplay was not created. The display pipeline failed and asked the server to quit, as it should.The server closed port 3389, but the process never exited. A stack sample of the stuck agent showed the main thread in tokio's blocking-pool shutdown, waiting for
update::watch, aspawn_blockingtask that sleeps for hours. launchd restarts the agent only after the process exits, so RDP stayed down until the process was killed by hand.Fix
After
servereturns,runtime.shutdown_timeout(2 s)replaces the unbounded wait, so the process exits and launchd starts a fresh server.Testing
cargo test: 51 passed; clippy-D warningsclean.🤖 Generated with Claude Code