Repository navigation
fix(antigravity): parse unterminated SSE events - #786
Open
outlier27-cell wants to merge 2 commits into
Open
outlier27-cell wants to merge 2 commits into
outlier27-cell wants to merge 2 commits into
Conversation
Contributor
Author
Collaborator
|
Thanks! I couldn't reproduce #784 on current |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Antigravity parsed
data:fields one line at a time during normal SSE reads, but treated an unterminated EOF buffer as one line. A valid multi-line event without its final blank delimiter therefore failed JSON parsing.Closes #784
Value
The provider accepts a valid final multi-line SSE event when a transport closes without its optional event delimiter.
Approach
data:line collector during normal reads and EOF processing.Validation
node --test --experimental-strip-types --test-name-pattern "unterminated multi-line SSE event" tests/extensions/ai-providers/antigravity.test.tsbun run checkbun run test(Windows baseline failures outside this change: file-lock/symlink-permission and existing TUI assertions)Impact
No API changes. Normal delimited SSE handling, timeouts, and cancellation behavior are unchanged.